Draft
Conversation
2dbcdaf to
2aa6e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements and refactoring to how term collections are defined and handled in the dataset, as well as minor enhancements to logging and helper management in the server initialization code. The most significant changes involve splitting the term collection type into distinct numeric and categorical variants, adding a new property for categorical collections, and improving retry logging for dataset initialization.
Refactoring and feature enhancements for term collections:
TermCollectiontype inshared/types/src/dataset.tsinto separateNumericTermCollectionandCategoricalTermCollectiontypes, allowing for more precise typing and future extensibility.categoryKeysproperty toCategoricalTermCollection, enabling explicit specification of which category attributes to use for categorical collections.server/dataset/termdb.test.tsto use the newcategoryKeysproperty for categorical term collections.Server initialization and logging improvements:
server/src/initGenomesDs.jsto include the retry delay in seconds, making retry messages more informative for debugging.mayLoghelper to the exporteddsHelpersobject inserver/src/initGenomesDs.jsfor more flexible logging capabilities.Checklist
Check each task that has been performed or verified to be not applicable.